fix: remove empty state package version checkbox - #1788
Conversation
f625d98 to
06cbf67
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1788 +/- ##
==========================================
+ Coverage 77.38% 77.39% +0.01%
==========================================
Files 102 102
Lines 3298 3300 +2
Branches 759 759
==========================================
+ Hits 2552 2554 +2
Misses 667 667
Partials 79 79 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
06cbf67 to
3065734
Compare
|
Hi @Dugowitch , where did you get an RPM package without a version? Such a package would be invalid by RHEL standards. |
|
Hi @swadeley, I don't know where it appeared in SPUR. When I tested it, I just commented out the if block in code to simulate it |
3065734 to
d0dd816
Compare
|
Hi @Dugowitch , @MichaelMraka checked the database, it will not allow you to store a package without a version. So no user should ever encounter this case. So this is just a fronted issue of mostly academic interest (a moot point). I'll will ACK so FE code looks logical. |
0ce938c to
5887e05
Compare
|
Yeah, I don't know how it happened but apparently, they stumbled upon it during SPUR |
5887e05 to
8086c88
Compare
8086c88 to
c99aaa9
Compare
3 participants
Description
Associated Jira ticket: HMS-11267
Remove checkbox for empty-state menu item and fix disabled.
How to test the PR
Find a package that has empty-state in it's Package details filter by 'version'. Check visually. Also, confirm that the checkbox is still present where applicable.
Before the change
After the change
Checklist: